Fix two defects found by Coverity

c-rack · May 20, 2015 · c6c48f5 · c6c48f5
1 parent 039201e
commit c6c48f5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/main/java/co/nstant/in/cbor/builder/AbstractBuilder.java b/src/main/java/co/nstant/in/cbor/builder/AbstractBuilder.java
@@ -92,7 +92,9 @@ private boolean isHalfPrecisionEnough(float value) {
             byte[] bytes = outputStream.toByteArray();
             ByteArrayInputStream inputStream = new ByteArrayInputStream(bytes);
             HalfPrecisionFloatDecoder decoder = getHalfPrecisionFloatDecoder(inputStream);
-            inputStream.read(); // to skip type byte
+            if (inputStream.read() == -1) { // to skip type byte
+                throw new CborException("unexpected end of stream");
+            }
             HalfPrecisionFloat halfPrecisionFloat = decoder.decode(0);
             return value == halfPrecisionFloat.getValue();
         } catch (CborException cborException) {

diff --git a/src/main/java/co/nstant/in/cbor/model/AbstractFloat.java b/src/main/java/co/nstant/in/cbor/model/AbstractFloat.java
@@ -26,7 +26,7 @@ public boolean equals(Object object) {
 
     @Override
     public int hashCode() {
-        return Objects.hashCode(value);
+        return super.hashCode() ^ Objects.hashCode(value);
     }
 
 }