Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timezone calculation logic in ghp-import is incorrect #45

Closed
lgp171188 opened this issue Aug 26, 2015 · 1 comment
Closed

Timezone calculation logic in ghp-import is incorrect #45

lgp171188 opened this issue Aug 26, 2015 · 1 comment

Comments

@lgp171188
Copy link
Contributor

The logic used is

currtz = "%+05d" % (-1 * time.timezone / 36) # / 3600 * 100

For my timezone IST (+0530), time.timezone returns -19800 which should translate to 5 hours 30 minutes. But the above code calculates it as +0550. This sets the timezone incorrectly in the commits created by ghp-import
lgp171188 added a commit to lgp171188/ghp-import that referenced this issue Aug 26, 2015
@lgp171188
Fix the incorrect timezone offset calculation (issue c-w#45)
31944ab
davisp pushed a commit that referenced this issue Dec 16, 2016
@lgp171188 @davisp
Fix the incorrect timezone offset calculation (issue #45)
3039877
@davisp
Copy link
Collaborator

davisp commented Dec 16, 2016

Fixed by cherry-picking your change.

@davisp davisp closed this as completed Dec 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davisp @lgp171188