Butcher not triggered when using Vagrant 1.7.1 and Butcher 2.2.0

[Yserz]

Butcher seems not to be triggered when using Vagrant 1.7.1 and Butcher 2.2.0. There's no error nor any other output.

[Yserz]

Thx 4 the fix :)

Unfortunately the client and node are not removed anymore on vagrant destroy :/. When I inspected the behavior in more detail I saw butcher is never creating his folder under the .vagrant folder.

Heres the log https://gist.github.com/Yserz/96ce0cd7e478a5b57dba

[c10l]

I couldn't reproduce this issue...
Would you mind trying it out with a clean vagrant install with only vagrant-butcher installed as a plugin? Just trying to isolate the problem as it might be caused by incompatibility with another plugin. Vagrant's plugin system is a bit of a moving target and not very well documented.
Also, if possible could you share your Vagrantfile and/or the base box you're using?
Thanks! :)

[Yserz]

For now I can give you the Vagrantfile and the box. I'll test it with a clean Vagrant when I have more time. Would it be sufficient to deinstall every plugin except the butcher one?

Vagrantfile: https://github.com/welovecoding/wlc-virtual-infrastructure/blob/master/vm-wlc-test/Vagrantfile
Unfortunately it's not executable without the whole infrastructure stuff :/

Box: https://atlas.hashicorp.com/wlc/boxes/centos-7.0

Note that chef is executed without any items in the runlist. Thus chef is not creating a node on the server (but a client). Maybe that's a part of the problem? On the other side butcher is never creating his butcher-folder so the problem is probably way before.

[c10l]

That should do it.

Thanks for the files. I'll try with them and see what happens.

[Yserz]

Okay, I figured out it's a problem with the vagrant-cachier plugin, again <.<
As soon as I add the line config.cache.scope = :box , which enables the plugin, butcher isn't working anymore. Probably they have the same problem with the changed attribute.

[c10l]

I see... Well, let's wait for @fgrehm on fgrehm/vagrant-cachier#133 . Hopefully when vagrant-cachier gets fixed this will work as expected.

[Yserz]

I was able to monkeypatch it like this:

# Fixes https://github.com/fgrehm/vagrant-cachier/issues/133
module VagrantPlugins
  module Cachier
    module Cap
      module Linux
        module ChefFileCachePath
          def self.chef_provisioner?(machine)
            provisioners = machine.config.vm.provisioners
            chef_provisioners = [:chef_solo, :chef_client]
            compat_provisioners = provisioners.keep_if { |p| chef_provisioners.include? p.name || p.type }
            if compat_provisioners.size > 1
              raise "One machine is using multiple chef provisioners, which is unsupported."
            end

            using_chef = compat_provisioners.empty? ? false : true
            using_chef
          end
          def self.chef_file_cache_path(machine)
            chef_file_cache_path = nil
            chef_file_cache_path = '/var/chef/cache' if chef_provisioner?(machine)

            return chef_file_cache_path
          end
        end
      end
    end
  end
end

VagrantPlugins::Cachier::Plugin.guest_capability 'linux', 'chef_file_cache_path' do
  VagrantPlugins::Cachier::Cap::Linux::ChefFileCachePath
end

Vagrantfile: require_relative 'path/to/patch.rb'

I can confirm butcher is working correctly with that cachier-patch.

[c10l]

The root cause of the interference between the plugins was identified by @sethvargo on hashicorp/vagrant#5060. I sent a pull request for vagrant-cachier to fix that.

[tknerr]

See also hashicorp/vagrant#5069 (for the provisioner name vs type issue)