Use project-wide properties and new dependency #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
KarlosQ
commented
Jul 19, 2018
KarlosQ
commented
- gradle 3.+ support
- Project-Wide properties support
- RN 0.56.+ support
* gradle 3.+ support * Project-Wide properties support * RN 0.56.+ support
|
Thanks for your PR. I'll test it ASAP. |
c19354837
reviewed
Jul 23, 2018
| } | ||
| } | ||
|
|
||
| dependencies { | ||
| compile "com.facebook.react:react-native:+" // From node_modules | ||
| implementation "com.facebook.react:react-native:+" // From node_modules |
There was a problem hiding this comment.
implementation requires gradle 3 +, so it'll force users who still use gradle 2 to upgrade.
I think it's better to keep it compile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.