Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not display buttons on associated routes on article view #467

Closed
brunobesson opened this issue Apr 4, 2019 · 3 comments
Closed

Do not display buttons on associated routes on article view #467

brunobesson opened this issue Apr 4, 2019 · 3 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@brunobesson
Copy link
Member

E.g. https://www.camptocamp.org/articles/219828/fr/mobilite-douce-sur-camptocamp

image

@brunobesson brunobesson added the bug Something isn't working label Apr 4, 2019
@cbeauchesne
Copy link
Member

Actually, on this example, there isn't any route associated to this article :

image

If there isn't any associated route, we must display the box, because we need the "add new route" button.

@cbeauchesne cbeauchesne added the question Further information is requested label Apr 5, 2019
@brunobesson
Copy link
Member Author

Then there is some UI workk to do maybe.

But, the link "See all associated routes" does return many many results... https://www.camptocamp.org/routes?c=219828
(that's why I reported the problem, didn't pay attention that there were so many results...)

@cbeauchesne
Copy link
Member

It's because API seems to not handle &c query. Actually, you see all existing routes with https://www.camptocamp.org/routes?c=219828

Until this is fixed on API, we should not display add button on this box, and in consequence, do not display the box if there is not association routes. Which means you are right from the beginning :)

@cbeauchesne cbeauchesne removed the question Further information is requested label Apr 5, 2019
@cbeauchesne cbeauchesne changed the title On articles, associated routes are not displayed Do not display buttons on associated routes on article view Apr 5, 2019
@cbeauchesne cbeauchesne self-assigned this Apr 5, 2019
cbeauchesne added a commit that referenced this issue Apr 5, 2019
…-box

Do not display buttons on associated routes on article view #467
@cbeauchesne cbeauchesne added this to the 7.0.4 milestone Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants