Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On Microsoft Edge - Can't save images when download #486

Closed
flob38 opened this issue Apr 8, 2019 · 3 comments
Closed

On Microsoft Edge - Can't save images when download #486

flob38 opened this issue Apr 8, 2019 · 3 comments
Labels
bug Something isn't working
Milestone
v7.0.5

Comments

@flob38
Copy link
Contributor

flob38 commented Apr 8, 2019 •
edited

With Microsoft Edge, when trying to add some images to a document, after you have chosen your files and put then in the image dowload box, you can't save them because the "Save" button is always desactivated (and the "trash" button doesn't appeared either).

A single error occurs when adding files :

SCRIPT438: Object doesn't support property or method 'toBlob'
ImageUploader.vue (169,1)
@flob38 flob38 added the bug Something isn't working label Apr 8, 2019
@flob38 flob38 changed the title Can't save images when download On Microsoft Edge - Can't save images when download Apr 8, 2019
cbeauchesne added a commit that referenced this issue Apr 9, 2019
@cbeauchesne
Add a polyfill for canvas.toblbob() #486
53959f3
@cbeauchesne cbeauchesne mentioned this issue Apr 9, 2019
Merged
cbeauchesne added a commit that referenced this issue Apr 9, 2019
@cbeauchesne
Merge pull request #498 from c2corg/fix-toblob-edge
1ebb687 
Add a polyfill for canvas.toblbob() #486
@cbeauchesne
Copy link
Member

@flob38 could you test with github pages please? (I do not have any way to test it with edge)...

Thanks a lot !

@cbeauchesne
Copy link
Member

When it's released, please leave a message on https://forum.camptocamp.org/t/ajouter-des-images/241357/10?u=charlesb

@cbeauchesne
Copy link
Member

Ok, tested and approved by @flob38 , thanks a lot!

@cbeauchesne cbeauchesne added this to the 7.0.5 milestone Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v7.0.5
Development

No branches or pull requests
2 participants
@cbeauchesne @flob38