Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move activities icons in associated route links #668

Merged
merged 1 commit into from Nov 7, 2019

Conversation

asaunier
Copy link
Member

As for now, when listing routes associated to an outing, the activities icons are shown first:

Capture d’écran 2019-06-10 à 16 30 21

This PR suggests to move them after the route name because:

  • the route name is the most important info, thus should be displayed first
  • the activities are a route info, like the gradings and heights, it's more consistent to group them
  • when several routes are associated, if several activities are available for a given route, it shifts the route names differently and makes it harder to read.

Here is what the change looks like:

Capture d’écran 2019-06-10 à 16 33 28

@asaunier
Copy link
Member Author

Perhaps it would be more consistent and helpful to add a route icon at the beginning of the line, as for the participants?

@cbeauchesne
Copy link
Member

I personally prefer icons in first, but it's matter of taste. Just be sure that any changes will be accepted by users, otherwise we'll pay huge cost after :)

Note that CI have deployed a ready-to-test version of your branch, it's easy to give URL to community to ged some feedback :

https://c2corg.github.io/c2c_ui/routelink-activities/#/outings/1119866/fr/calanque-d-en-vau-eperon-des-americains
vs
https://c2corg.github.io/c2c_ui/master/#/outings/1119866/fr/calanque-d-en-vau-eperon-des-americains

@stale
Copy link

stale bot commented Sep 8, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issue with no activity, will be close soon label Sep 8, 2019
@asaunier
Copy link
Member Author

asaunier commented Sep 8, 2019

Sans déconner...

@stale stale bot removed the stale Issue with no activity, will be close soon label Sep 8, 2019
@cbeauchesne
Copy link
Member

cbeauchesne commented Sep 9, 2019

Oups, I've forgotten to follow this one... What was the the status, we discuss about it on the forum ?

@brunobesson brunobesson merged commit e45e19e into master Nov 7, 2019
@brunobesson brunobesson deleted the routelink-activities branch November 7, 2019 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants