Allow to associate article from outing detail view page #1290
Conversation
| @@ -88,7 +88,8 @@ app.AddAssociationController.prototype.associate = function(doc) { | |||
| // if the parent doc is a route and the child doc is a waypoint OR | |||
| // if the parent doc is an outing, inverse the IDs. | |||
| if ((parentType === 'routes' && doc['type'] === 'w') || | |||
| parentType === 'outings' || parentType === 'images' || | |||
| (parentType === 'outings' && (doc['type'] === 'r' || doc['type'] === 'u')) || | |||
There was a problem hiding this comment.
I am not sure to understand this change. Isn't article type missing here?
There was a problem hiding this comment.
Outings were swapped to be child in all added associations on the outing view page (but in the case of articles we should keep them as children in its association to outings and there is no need to include them here - for outings only route/user should be swapped). https://github.com/c2corg/v6_common/blob/master/c2corg_common/associations.py#L7-L8
There was a problem hiding this comment.
OK thanks for the explanations.
To be honest I think this part is getting a bit confusing and not easy to understand. I don't know if we could do something to make it more explicit?
|
I have merged the PR because we would like to update the demo soon :) |
Related to #1284
It is now able to associate articles (and routes) from outing detail view page