Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI/CD pipeline and ensure successful deployment #138

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

lokeshwar777
Copy link
Collaborator

This PR addresses issues within the CI/CD pipeline to ensure successful deployment. It resolves #137.

Description

This PR addresses several issues within the CI/CD pipeline to ensure successful deployment of the project. The following changes were made:

  1. Corrected the image path in the CodelabCard component (commit 050dc30).
  2. Updated Firebase deployment workflows and configuration for production (commit 965248e).
  3. Removed the obsolete main.yml (commit 0ad62a1).
  4. Resolved build warnings by removing border-radius from input components (commit ff787fb).
  5. Updated vite npm dependency to version 5.2.12 (commit 587c447).
  6. Updated .gitignore to include the /dist directory and exclude package-lock.json (commit cc638fa).
  7. Updated Node.js version to 18 in the functions package.json (commit 2fac50e).

Note: One of the tests failed due to an issue with the editor, not the vite dependency. We need to investigate and address this issue.

Related Issue

Fixes #137

Motivation and Context

The CI/CD pipeline was failing due to several issues, including unresolved imports, build warnings, and outdated configurations. These changes are necessary to ensure that the pipeline completes successfully and the application is deployed without errors.

How Has This Been Tested?

The changes were tested by running the CI/CD pipeline multiple times to ensure that the errors were resolved and the application was deployed successfully. However, one of the tests failed after updating vite from version 4 to version 5. Further investigation is needed to address this issue. The testing environment included:

  • OS: macOS
  • Browser: Chrome
  • Version: 125.0.6422.141 (Official Build) (arm64)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix CI/CD pipeline and ensure successful deployment
2 participants