Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Fix : Implemented The Option to Add&Remove Editor (1), Admins (2), Reviewers (0) to Organization ] #77

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rohitPandey469
Copy link

Description

The OrgUsersCard wasn't using the addOrgUserModal which is already present, so I fixed it by opening the addOrgUserModal on clicking the + Add New button, afterwards when the Modal is opened, it shows list of all the users having access to the organization including the option to search an organization user and remove lower leveled permission users. And the modal has a +Add New button as well which adds users to that organization.
Now when a tutorial is created by a user in an organization then all other users present in that org. have access to edit it.

Related Issue

Fixes #76

Motivation and Context

Adding an option to add and remove users in an organization with permission.

How Has This Been Tested?

Tested locally on my machine.

Video reference:

What I am doing here?
Logged in through Sarfraz id and Rohit id ( org. for this is created by me manually - the org. creation issue is solved in another PR ) then in the youtube org. of Sarfraz ( whose access only sarfraz have ) chose rohithandle as the Admin of the youtube ( permission level 2 ), now tutorial created inside youtube can be edited by both the users.

Screen.Recording.-.Feb.23.2024.mp4

Here shown some more glimpse of it, actually it was already implemented or present in the code I just connected everything and fixed something to make it work.

Screen.Recording.-.Feb.23.2024.1.mp4

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly..
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Note:

  1. I have used the already present code in orgUserCard and connected it - might be that it wasn't connected or left and no one noticed cause in previous PR's the guy created a new modal to do the same work.
  2. Adding the users with permission level. So, will use it further to allow edit. ( like Reviewer can't edit or something )
  3. I tried to copy file changes from PR this Site Breaks When Navigating to Organization Page scorelab/Codelabz#1036 but it's not working, so I created the org. manually through firebase for rohithandle. ( I dunno one of the guy was saying that it's fixed - well it's not )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ Fix : Adding Users ( Reviewer, Editor, Admin ) to an Organization via 'Add New' Button ]
1 participant