Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This is closed due to some issues don't go through it. #95

Closed
wants to merge 10 commits into from
Closed

This is closed due to some issues don't go through it. #95

wants to merge 10 commits into from

Conversation

Hemu21
Copy link

@Hemu21 Hemu21 commented Feb 25, 2024

When you click on logout button then user should redirect to the home page. This is the actual feature of any website but logout is not redirecting to home page instead it is redirecting to login page. This is the bug by Fixed it we can increase user experience.

Description

I changed the redirecting path of the logout button. Now it redirects to home page not to login page. I created test for it and checked everything works perfectly.

Related Issue

Logout not Redirecting to home page resolve #94

steps to reproduce

  • Setup the localhost and run it.
  • Now login to the website.
  • You can logout via navbar or profile icon menu
  • After logout user should see the home page but getting login page.
logou_redirect_home_issue.mp4

Link of the Issue

https://github.com/c2siorg/Codelabz/issues/94

Motivation and Context

When you click on logout button then user should redirect to the home page. This is the actual feature of any website but logout is not redirecting to home page instead it is redirecting to login page. This is the bug by fixing it we can increase user experience. If user not redirected to home page then user can't see the website home page after logout.

"we can get into login again from home page but we can't get into home page from login page."

How Has This Been Tested?

  • Setup the localhost and run it.
  • Now login to the website.
  • You can logout via navbar or profile icon menu
  • After logout user should see the home page as below.

Screenshots or GIF (In case of UI changes):

logout_redirect_home_issue_fix.mp4

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Review Request

@ABHISHEK-PANDEY2 @Maahi10001 @Shiva-Nanda @c2sibot Please Review My PR. Approve My PR

@Hemu21 Hemu21 closed this by deleting the head repository Feb 25, 2024
@Hemu21 Hemu21 changed the title Logout not Redirecting to home page #94 Fixed This is closed due to some issues #94 Fixed Feb 26, 2024
@Hemu21 Hemu21 changed the title This is closed due to some issues #94 Fixed This is closed due to some issues don't go through it. Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logout not Redirecting to home page
1 participant