Skip to content

Commit

Permalink
fix pkix name parsing
Browse files Browse the repository at this point in the history
  • Loading branch information
c3b2a7 committed Jul 6, 2023
1 parent 1e2dbda commit c788b18
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions ca/internal/util.go
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ var applierList = map[string]func(name *pkix.Name, value any){
}

func ParsePKIXName(name string) (pkixName pkix.Name) {
nTok := NewTokenizer(name, ',')
nTok := NewTokenizer(name, '/')
for nTok.HasMoreTokens() {
token := nTok.NextToken()

Expand Down Expand Up @@ -157,7 +157,7 @@ func ParsePKIXName(name string) (pkixName pkix.Name) {
} else {
applier(&pkixName, value)
}
} else {
} else if token != "" {
vTok := NewTokenizer(token, '=')
attribute := vTok.NextToken()
if !vTok.HasMoreTokens() {
Expand Down
2 changes: 1 addition & 1 deletion ca/internal/util_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import (
)

func TestParsePKIXName(t *testing.T) {
pkixName := ParsePKIXName("C=CN,O=Easy CA,OU=IT Dept.,CN=Easy Root CA")
pkixName := ParsePKIXName("/C=CN/O=Easy CA/OU=IT Dept./CN=Easy Root CA")
if pkixName.String() == "" {
t.Errorf("error to parse pkix name")
}
Expand Down

0 comments on commit c788b18

Please sign in to comment.