Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change D3 to peerDependencies. #1106

Closed
gilbarbara opened this issue Apr 7, 2015 · 3 comments
Closed

change D3 to peerDependencies. #1106

gilbarbara opened this issue Apr 7, 2015 · 3 comments

Comments

@gilbarbara
Copy link

I'm using c3 in a project where I also need to have d3 installed with the latest version (3.5.5).
But using browserify to bundle my app, c3 carries its own copy of d3 (<= 3.5.0) meaning duplicate code..

cheers

@aendra-rininsland
Copy link
Member

This isn't a bad idea at all; I use C3 in lots of projects where I also use D3. 👍

@ustccjw
Copy link

ustccjw commented Aug 27, 2015

+1, and d3 version <= 3.5.0 depend jsdom(which depend contextify), but contextify can not work well in iojs (see brianmcd/contextify#173)

@aendra-rininsland
Copy link
Member

Worth seeing the discussion in #1166 re: peerDependencies (They don't work like you think they should in newer versions of NPM, so therefore we probably won't use them as such).

Closing as a duplicate, please see #1062.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants