Skip to content
This repository has been archived by the owner on Dec 9, 2018. It is now read-only.

Will not compile on iojs 3.0 (need to update nan) #173

Closed
MylesBorins opened this issue Aug 5, 2015 · 5 comments
Closed

Will not compile on iojs 3.0 (need to update nan) #173

MylesBorins opened this issue Aug 5, 2015 · 5 comments

Comments

@MylesBorins
Copy link

This is due to major breaking changes in v8 that require an update to nan (to 2.0.0).

I am currently trying to figure out exactly what the update entails, as it appears it is a bit more of a pain than the last round of nan updates (change to api).
@MylesBorins MylesBorins changed the title Will not compile on iojs 3.0 Will not compile on iojs 3.0 (need to update nan) Aug 5, 2015
bruderstein added a commit to bruderstein/react-select that referenced this issue Aug 6, 2015
@bruderstein
Peg version of io.js to 2.5.0 for travis
1897d74 
Currently issue JedWatson#173 (brianmcd/contextify#173) of contextify is causing all PRs to fail on io.js.
Until this issue is resolved, I'd recommend pinning the io.js version to v2.5.0 (the last in the 2.x line), such that we get accurate status from travis.

This can be reverted when the issue with contextify is resolved.
@bruderstein bruderstein mentioned this issue Aug 6, 2015
Merged
@sanemat
Copy link

sanemat commented Aug 17, 2015

😿

@bpdp
Copy link

bpdp commented Aug 21, 2015

Same issue here with iojs 3.1.0. Update nan to 2.0.5 doesn't help.

@ustccjw ustccjw mentioned this issue Aug 27, 2015
Closed
@davidlehn davidlehn mentioned this issue Aug 28, 2015
Closed
@thom4parisot
Copy link

Have you had a look at https://github.com/nodejs/nan/blob/master/CHANGELOG.md#200-jul-31-2015?

Otherwise we should ask for some help to @rvagg or someone else who knows well how to transition to Node 4.x etc.

@rvagg rvagg mentioned this issue Sep 10, 2015
Closed
@rvagg
Copy link
Contributor

rvagg commented Sep 10, 2015

#181 (not working, but a start)

@brianmcd
Copy link
Owner

Fixed in 0.1.15

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@sanemat @thom4parisot @rvagg @MylesBorins @bpdp @brianmcd