Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update updateSvgSize to be less fragile #2525

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update updateSvgSize to be less fragile #2525

wants to merge 2 commits into from

Commits on Nov 6, 2018

  1. Update core.js 

    selection.selectAll doesn't support array syntax
    @beninsocrata
    beninsocrata committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    92ab093 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2018

  1. Update core.js updateSvgSize use of selectAll 

    Forgot to take out the array brackets in the first commit. The array version is fragile in our platform, so using the common comma separated string of selectors instead.
    @beninsocrata
    beninsocrata committed Nov 12, 2018
    Configuration menu
    Copy the full SHA
    9276ba0 View commit details
    Browse the repository at this point in the history