Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added configs to set the labels position. #57

Closed
wants to merge 1 commit into from

Conversation

bastiao
Copy link
Contributor

@bastiao bastiao commented Mar 6, 2014

I just created options to set the label position of the axis. I just added label_position to keep backport compatibility. Do you have other suggestion?

By the way, is possible that padding bottom is broken?

@masayuki0812
Copy link
Member

Hi, is the purpose of this option is to change the position of label to outside of axis?
If so, I think It's reasonable to add an option for it and I'll do it.

And currently, there is no option for padding.bottom and it is needed to expand axis region for the label moved. I think it's better to be done with the option I wrote above.

@bastiao
Copy link
Contributor Author

bastiao commented Mar 6, 2014

Yes, it is! So I agree.

My problem is: when I tried it works very fine in the Y. But in the X it was cutted off. Any idea?

Are you going to do that?

@masayuki0812
Copy link
Member

OK, I see. I'll add an option for the position of labels.

The reason of cut off is that the size of region of axis is limited by height 40 (I think). So if position is over that, it will not be shown. For y axis, there is a padding for the left. So it can be shown.

@bastiao
Copy link
Contributor Author

bastiao commented Mar 6, 2014

Can you fix that? It will be great!

@masayuki0812
Copy link
Member

Yes, please give me some time. I create the issue #59 for that, so I close this PR.

@masayuki0812
Copy link
Member

@bastiao I added axis.x.label.position and axis.y.label.position. Please try these.
Sample is here http://c3js.org/samples/axes_label_position.html

@bastiao
Copy link
Contributor Author

bastiao commented Mar 8, 2014

It's perfect!!

By the way, not all your samples are in github. You should add to keep consistency. :) Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants