Texture #13
Merged
Texture #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshChristie
reviewed
Oct 6, 2016
| Overwrite points or lines with the same label | ||
|
|
||
| See plot3d for documentation | ||
| """ |
There was a problem hiding this comment.
This doc should be updated for images :P
There was a problem hiding this comment.
And I should also add some documentation for the two functions above.
|
|
||
| #------------------------------------------------------------------------------- | ||
| # Texture file | ||
| function write_ply(texturefile::String, filename::String, vertices::AbstractArray) |
There was a problem hiding this comment.
Maybe this should be called write_ply_texture?
There was a problem hiding this comment.
You're right, it's not a generic ply-writer, thanks.
|
Thanks for the review @JoshChristie , I fixed it up |
|
Thanks Jan, I just had a look this looks great. Also thanks a heap Josh for reviewing it. Just one comment - perhaps |
|
Done, thanks Chris. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple image loading via texture files. plotimage() takes a 4x3 matrix for the corners of the image and a path to an image file.