Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: write better result/lexure code based on review #3

Merged
merged 4 commits into from
Jul 30, 2022
Merged

fix: write better result/lexure code based on review #3

merged 4 commits into from
Jul 30, 2022

Conversation

samfundev
Copy link

No description provided.

c43721
c43721 requested changes Jul 29, 2022
View reviewed changes
Copy link
Owner

@c43721 c43721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, a few comments

src/lib/parsers/Args.ts Show resolved Hide resolved
src/arguments/CoreBoolean.ts Outdated Show resolved Hide resolved
src/lib/structures/Command.ts Show resolved Hide resolved
@samfundev
Copy link
Author

@c43721 Just to clarify, this PR is ready for review and the unit tests are failing because of 747be01.

@samfundev samfundev requested a review from c43721 July 30, 2022 01:56
@c43721 c43721 merged commit 6c69769 into c43721:chore/result-2 Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c43721 c43721 c43721 approved these changes

Assignees

@samfundev samfundev

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@samfundev @c43721