Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't let non-form-owner add voters #115

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Don't let non-form-owner add voters #115

merged 1 commit into from
Feb 15, 2024

Conversation

ineiti
Copy link
Member

@ineiti ineiti commented Feb 15, 2024

Also adds a test in the script directory to make sure this doesn't pass anymore.

Closes #81

Thank you for opening a pull request with this project, please also:

  • add a brief description of your changes here
  • assign the PR to yourself, or to the person(s) working on it
  • start in draft mode and in progress pipeline in the project (if applicable)
  • if applicable, add this PR to its related issue by one of the special keywords Closing keywords
  • once it's ready
    • put it in the Review or Ready4Merge pipeline in the project (if applicable)
    • remove draft
    • assign a reviewer

@ineiti ineiti self-assigned this Feb 15, 2024
@ineiti ineiti marked this pull request as ready for review February 15, 2024 08:22
Copy link
Member

@PascalinDe PascalinDe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - there is a second admin in the Docker environment I added for manually testing things in my local instance (which is not needed for the automatic tests)

I didn't add it to the local environment setup as it is not required for anything other than my convenience, shall I add it anywayy?

@ineiti
Copy link
Member Author

ineiti commented Feb 15, 2024

I didn't add it to the local environment setup as it is not required for anything other than my convenience, shall I add it anywayy?

Let's wait if we have other tests with two admins.

@ineiti
Copy link
Member Author

ineiti commented Feb 15, 2024

Once #116 is merged, I rebase on this, and then hopefully it passes...

Also adds a test in the script directory to make sure this doesn't pass anymore.

Closes #81
@ineiti ineiti merged commit 9667bff into main Feb 15, 2024
11 checks passed
@ineiti ineiti deleted the block_admin_changes branch February 15, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Non-owner can add voters to form of other user
2 participants