New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup frontend #18

Merged

ineiti merged 2 commits into main from cleanup_frontend

Oct 4, 2023

Member

ineiti commented Oct 4, 2023

Two commits to cleanup:

one fixing a linter error with a throw in a catch block
one changing the dev login to only be allowed if REACT_APP_DEV_LOGIN === 'true'

ineiti added 2 commits

October 4, 2023 09:03


          Adding logging variables and cleaning up a throw within a catch

68cdb33


          Only allowing dev login if REACT_APP_DEV_LOGIN === 'true'

76acfb0

ineiti self-assigned this

ineiti requested review from lanterno and PascalinDe

October 4, 2023 07:33

PascalinDe approved these changes

View reviewed changes

Member

PascalinDe left a comment

LGTM

ineiti merged commit 6fc65fc into main

8 of 10 checks passed

ineiti deleted the cleanup_frontend branch

October 4, 2023 08:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment