QUESTION: Forking?

[EricTheMagician]

Hi c4milo,

I liked the idea of using the fuse low-level api (especially with the asynchronous api) with nodeJS.
The code you had written was not working, and there are several issues suggesting a rewrite is needed.

I've made some minor (or maybe major?) modifications to it and it now works. If anyone is interested, have a look at https://github.com/thejinx0r/fusejs/tree/dev. The performance is great because fuse can run in multithreaded mode and the developer does not need to worry about that on the JS side!

I was thinking of releasing the changes back to the public, and I was wondering how should I proceed?
Should I create a new package and acknowledge your work, or create a pull request and merge the code in?

I haven't enabled all the functions yet, but it should be straightforward to get everything to work.

Eric

[c4milo]

Hey Eric! nice work! It is definitely your decision whether you want to create a new package or contribute your changes back to this project. I went ahead and added you as collaborator if you want to merge your changes back. I already reviewed your code too and it looks good to me!

[EricTheMagician]

I'll definitely merge it back to this repo here when I get some time.
It will probably happen in July. I also wanted to finish off the other functions before pushing it.

Thanks for adding me as collaborator and thanks for the initial code base. This is pretty amazing

[c4milo]

I'm glad to hear that. Looking forward to it.
On Thu, Jun 18, 2015 at 7:51 AM thejinx0r notifications@github.com wrote:

I'll definitely merge it back to this repo here when I get some time.
It will probably happen in July. I also wanted to finish off the other
functions before pushing it.

—
Reply to this email directly or view it on GitHub
#14 (comment).

[EricTheMagician]

Question on copyright:
In the cpp/.h files, there are copyright's, e.g. // Copyright 2012, Camilo Aguilar. Cloudescape, LLC.
What should happen to those?

I thought about just removing those, but I'm not sure what the implication would be, if there are any.

[c4milo]

Yeah, I re-licensed all my open source projects to use MPL2. You can use either your IDE or https://github.com/c4milo/licentia to do that.

[EricTheMagician]

I'm looking in to publishing the code on npmjs.org.
I think you need to add me as a collaborator on npmjs as well so that I can publish a newer version on npmjs.

[c4milo]

@thejinx0r looking into it

[c4milo]

@thejinx0r done.