-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minor bug --new-version = old-version #30
Comments
I wrote a test, and fixed it, but this broke other things such as test_multi_file_configuration2, which looks somewhat odd to me. |
test_multi_file_configuration2 is not just odd, it is incorrect. Running with the original code inside a debugger we get:
which, while not desirable behavior, does satisfy the inadequate assertion:
|
This looks suspiciously like #127 but it's not the same bug -- only the same outcome. What should bumpversion do when Or fail with a message and return a non-zero error code? |
It would be nice if it moved on as if everything is okay. I ran into this issue while trying to do some automation. I'm trying to write a script that runs bumpversion without committing, grabs the new version and uses it to create a release branch Edit: I realized I'm dumb and it won't work like I'm expecting. I now don't have a particular opinion. |
Ran into this issue also. @florisla I would say move on as if everything is OK. I would say you generally call bump2version on purpose, so that you know you are calling it with a similar version. In that case fail bump2version is not necessary. Maybe good to add a warning or so. |
If you use the
--new-version
flag with the current version as an argument, bumpversion corrupts the files :(. I ended up with:The text was updated successfully, but these errors were encountered: