lint the code with pylint #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
reviewed
Mar 26, 2019
|
|
||
| def __init__(self, first_value=None): | ||
|
|
||
| if first_value is not None: | ||
| try: | ||
| part_prefix, part_numeric, part_suffix = self.FIRST_NUMERIC.search( | ||
| _, _, _ = self.FIRST_NUMERIC.search( |
There was a problem hiding this comment.
If all are unused, can you just remove the result? Wouldn't it be cleaner to do:
match = self.FIRST_NUMERIC.search(first_value)
if not match:
raise ValueError("The given first value {} does not contain any digit".format(first_value))| from bumpversion.exceptions import WorkingDirectoryIsDirtyException, MercurialDoesNotSupportSignedTagsException | ||
| from bumpversion.exceptions import ( | ||
| WorkingDirectoryIsDirtyException, | ||
| MercurialDoesNotSupportSignedTagsException |
There was a problem hiding this comment.
Personally I'm a fan of trailing commas since it makes the diff smaller when you're adding another import.
florisla
added a commit
to florisla/bump2version
that referenced
this pull request
Apr 17, 2019
Pylint config: see c4urself#67
florisla
added a commit
to florisla/bump2version
that referenced
this pull request
Apr 17, 2019
This also adds a pylintrc for future PRs.
This was behaving differently between Python 2 and 3, causing test 'test_dirty_work_dir' to fail in one of both.
|
Not sure what's going on with AppVeyor, maybe someone with more windows experience can help out, the difference seems to be the version of tox... |
florisla
added a commit
to florisla/bump2version
that referenced
this pull request
Jun 13, 2019
Pylint config: see c4urself#67
martinm82
pushed a commit
to martinm82/bump2version
that referenced
this pull request
Nov 17, 2020
Pylint config: see c4urself#67
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also adds a pylintrc for future PRs.