Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gem, mainly add tests #1

Merged
merged 18 commits into from
Nov 25, 2011
Merged

Update gem, mainly add tests #1

merged 18 commits into from
Nov 25, 2011

Conversation

Koronen
Copy link
Collaborator

@Koronen Koronen commented Nov 8, 2011

Hi Peter!

I've made some updates to your gem:

  • Added bundler to handle development dependencies
  • Added rspec and wrote some tests for public methods
  • Added guard for automatic testing
  • Added cover_me to show test coverage

I've also made slight modifications to a couple of methods that made sense to me:

  • initialize now throws ArgumentError when an invalid argument is passed
  • age is now (re)calculated on request, since it is time dependent
  • to_s always returns the standard form, e.g. 'yymmdd-xxxx'
  • Fixed a suspected typo for the "Värmlands län" region

Lastly, I also bumped the version number, since version 0.0.4 is on rubygems already.

I'll gladly accept feedback.

Cheers,
Victor Koronen

peterhellberg added a commit that referenced this pull request Nov 25, 2011
Update gem, mainly add tests
@peterhellberg peterhellberg merged commit 995f611 into c7:master Nov 25, 2011
@peterhellberg
Copy link
Member

Really nice work! (Holman helped me figure out why I didn’t get any notification of your pull request)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants