Skip to content
This repository has been archived by the owner on Apr 6, 2021. It is now read-only.

Custom plugins not loading anymore #157

Closed
psychocrackpot opened this issue Sep 17, 2015 · 4 comments
Closed

Custom plugins not loading anymore #157

psychocrackpot opened this issue Sep 17, 2015 · 4 comments

Comments

@psychocrackpot
Copy link

I can't load my custom plugins in either debug mode or normal mode. I have re-published and tried to install for local with no success

@3mg
Copy link

3mg commented Sep 17, 2015

Same problem. Also menu items "File/New Plugin/Full Plugin" and "Tools/Developer/Start in Debug Mode" disappeared.

@Pike
Copy link
Contributor

Pike commented Sep 17, 2015

Haven't updated myself yet, but from reading the recent landings, there should be a "Experiments" section in the prefs exposing checkboxes for at least some of this.

Could you check? Mostly curious before I update myself ;-)

@nightwing
Copy link
Member

Sorry, there was a bug in code that adds 'Experiments' panel, and it disabled sdk.
We'll push a fix for this later today.

diff --git a/plugins/c9.ide.preferences/experimental.js b/plugins/c9.ide.preferences/experimental.js
index a959583..15d233b 100644
--- a/plugins/c9.ide.preferences/experimental.js
+++ b/plugins/c9.ide.preferences/experimental.js
@@ -61,9 +61,6 @@ define(function(require, exports, module) {
         // =1 means the value should be set to 1 to enable otherwise it is disabled
         var found = {};
         function addExperiment(query, name){
-            if (found[name]) return;
-            found[name] = true;
-            
             var key = query.split("=");
             var defValue = Number(key[1]); key = key[0];
             var uniqueId = key.replace(/\//g, "-");
@@ -76,7 +73,9 @@ define(function(require, exports, module) {
             current.type = "checkbox";
             current.setting = "state/experiments/@" + uniqueId;

-            plugin.add(obj, plugin);
+            if (!found[name])
+                plugin.add(obj, plugin);
+            found[name] = true;

             settings.setDefaults("state/experiments", [[uniqueId, !defValue]]);

@nightwing
Copy link
Member

This is fixed now, please comment if you still see any issues related to this

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants