Update CurlDownloader.php #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
使用http proxy 返回的原始数据为 HTTP/1.1 200 OK Date: Monday, 26-Feb-18 12:01:58 CST Keep-Alive: timeout=38 Content-Length: 0 HTTP/1.1 200 OK Date: Mon, 26 Feb 2018 04:01:59 GMT Server: Apache/2.4.25 (Debian) Last-Modified: Sun, 31 Dec 2017 04:18:46 GMT ETag: "6c5-5619b297052f6" Accept-Ranges: bytes Content-Length: 1733 Vary: Accept-Encoding Strict-Transport-Security: max-age=31536000 Content-Type: application/xml <?xml version="1.0" encoding="UTF-8" ?> ....... 在http proxy模式下，会导致phpbrew ext known $ext 和 phpbrew ext install $ext $version报错
c9s
approved these changes
Apr 8, 2019
morozov
reviewed
Aug 12, 2019
| @@ -165,7 +165,7 @@ public function request($url, $params = array(), $options = array() ) | |||
|
|
|||
| // When using HTTP TUNNEL, there is an extra response line before the | |||
| // original response line, we need to separate them if it matches "Connection established" | |||
| if (preg_match('#HTTP/1.[0-1] 200 Connection established#i', $data)) { | |||
| if (preg_match('#HTTP/1.[0-1] 200#i', $data)) { | |||
There was a problem hiding this comment.
@c9s are you sure this is the right change? It contradicts the comment and breaks the PhpBrew build after an update to the latest version of the library. See phpbrew/phpbrew#1038, build #570616613.
This was referenced Nov 28, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
使用http proxy 返回的原始数据为
在http proxy模式下，会导致phpbrew ext known $ext 和 phpbrew ext install $ext $version报错