Remove unnecessary if expr

c9s · Jul 18, 2016 · 7ec61fc · 7ec61fc
1 parent e86ab18
commit 7ec61fc
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/src/OptionParser.php b/src/OptionParser.php
@@ -174,12 +174,11 @@ public function parse(array $argv)
             if (!$spec) {
                 throw new InvalidOptionException('Invalid option: '.$arg);
             }
-            if ($spec->isRequired() || $spec->isMultiple() || $spec->isOptional() || $spec->isFlag()) {
-                $i += $this->consumeOptionToken($spec, $arg, $next);
-                $result->set($spec->getId(), $spec);
-            } else {
-                throw new Exception('Unknown option type');
-            }
+
+            // This if expr might be unnecessary, becase we have default mode - flag
+            // if ($spec->isRequired() || $spec->isMultiple() || $spec->isOptional() || $spec->isFlag()) {
+            $i += $this->consumeOptionToken($spec, $arg, $next);
+            $result->set($spec->getId(), $spec);
         }
 
         return $result;