bbgo: check base balance only for long position

c9s · Sep 11, 2022 · db94b26 · db94b26
1 parent b805b19
commit db94b26
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/config/bollmaker.yaml b/config/bollmaker.yaml
@@ -195,7 +195,7 @@ exchangeStrategies:
     tradeInBand: true
 
     # buyBelowNeutralSMA: when this set, it will only place buy order when the current price is below the SMA line.
-    buyBelowNeutralSMA: false
+    buyBelowNeutralSMA: true
 
     exits:
 

diff --git a/pkg/bbgo/order_executor_general.go b/pkg/bbgo/order_executor_general.go
@@ -272,8 +272,13 @@ func (e *GeneralOrderExecutor) ClosePosition(ctx context.Context, percentage fix
 	}
 
 	// check base balance and adjust the close position order
-	if baseBalance, ok := e.session.Account.Balance(e.position.Market.BaseCurrency); ok {
-		submitOrder.Quantity = fixedpoint.Min(submitOrder.Quantity, baseBalance.Available)
+	if e.position.IsLong() {
+		if baseBalance, ok := e.session.Account.Balance(e.position.Market.BaseCurrency); ok {
+			submitOrder.Quantity = fixedpoint.Min(submitOrder.Quantity, baseBalance.Available)
+		}
+		if submitOrder.Quantity.IsZero() {
+			return fmt.Errorf("insufficient base balance, can not sell: %+v", submitOrder)
+		}
 	}
 
 	tagStr := strings.Join(tags, ",")