-
-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add forceOrder api for binance to show liquid info #1232
Conversation
Welcome back! @zenixls2, This pull request may get 322 BBG. |
6f1c322
to
9cfe7d3
Compare
Re-estimated karma: this pull request may get 331 BBG |
9cfe7d3
to
d1c189d
Compare
Re-estimated karma: this pull request may get 336 BBG |
d1c189d
to
9c9c830
Compare
Re-estimated karma: this pull request may get 341 BBG |
9c9c830
to
5ce437c
Compare
Re-estimated karma: this pull request may get 354 BBG |
5ce437c
to
c538240
Compare
Re-estimated karma: this pull request may get 376 BBG |
Codecov Report
@@ Coverage Diff @@
## main #1232 +/- ##
==========================================
- Coverage 20.86% 20.78% -0.08%
==========================================
Files 556 558 +2
Lines 39621 39779 +158
==========================================
+ Hits 8265 8269 +4
- Misses 30757 30910 +153
- Partials 599 600 +1
... and 17 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
c538240
to
31a6819
Compare
Re-estimated karma: this pull request may get 386 BBG |
31a6819
to
7ae56a8
Compare
Re-estimated karma: this pull request may get 391 BBG |
@c9s Tested in the
log dumped from modified skeleton. |
Re-estimated karma: this pull request may get 404 BBG |
@c9s ready to be merged. |
pkg/exchange/binance/parse.go
Outdated
@@ -530,6 +533,63 @@ func parseDepthEvent(val *fastjson.Value) (*DepthEvent, error) { | |||
return depth, err | |||
} | |||
|
|||
type ForceOrderEventInner struct { | |||
Symbol string `json:"s"` | |||
TradeTime int64 `json:"T"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can use types.MillisecondTime here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Re-estimated karma: this pull request may get 423 BBG |
Hi @zenixls2, Well done! 438 BBG has been sent to your polygon wallet. Please check the following tx: https://polygonscan.com/tx/0x2870224e7340f3a483292cbd3f6f55fa18c7b7e6e20b756ce32749be266f2f0e Thank you for your contribution! |
Show the forced liquidation event from binance.