Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: [max] remove outdated margin fields #1343

Merged
merged 1 commit into from Oct 18, 2023

Conversation

gx578007
Copy link
Collaborator

No description provided.

@gx578007 gx578007 requested review from c9s and kbearXD October 17, 2023 07:46
@bbgokarma-bot
Copy link

Welcome back! @gx578007, This pull request may get 212 BBG.

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #1343 (10daeab) into main (d50e509) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1343   +/-   ##
=======================================
  Coverage   20.70%   20.70%           
=======================================
  Files         560      560           
  Lines       40025    40025           
=======================================
  Hits         8287     8287           
  Misses      31136    31136           
  Partials      602      602           
Files Coverage Δ
pkg/exchange/max/maxapi/account.go 0.00% <ø> (ø)
pkg/exchange/max/exchange.go 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d50e509...10daeab. Read the comment docs.

@gx578007 gx578007 force-pushed the bhwu/max/remove-outdated-max-fields branch from 361ccc7 to 10daeab Compare October 17, 2023 08:11
@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 222 BBG

@gx578007 gx578007 merged commit 5c8c66a into main Oct 18, 2023
3 of 4 checks passed
@gx578007 gx578007 deleted the bhwu/max/remove-outdated-max-fields branch October 18, 2023 07:41
@bbgokarma-bot
Copy link

Hi @gx578007,

Well done! 227 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0x07cc33130f2bb8503e0781992744d61600ff8401dc667c8324852dd5aa2bfdfb

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants