FEATURE: [grid2] twin orderbook #1350
Conversation
|
Hi @kbearXD, This pull request may get 403 BBG. To receive BBG token, please left your polygon address as an issue comment in this pull request with the following format, e.g., Once this pull request is merged, your BBG token will be sent to your wallet. |
|
Re-estimated karma: this pull request may get 456 BBG |
Codecov Report
@@ Coverage Diff @@
## main #1350 +/- ##
==========================================
+ Coverage 20.76% 20.93% +0.17%
==========================================
Files 566 566
Lines 40357 40554 +197
==========================================
+ Hits 8380 8491 +111
- Misses 31368 31446 +78
- Partials 609 617 +8
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
polygon:0x8642D208dce7214De9F222d864383968B5C346C7 |
|
Hi @kbearXD, You left an invalid address format, please write your address with the following format: |
|
Great! @kbearXD, I've memorized your address. |
| // sort it in asc order | ||
| sort.Slice(v, func(i, j int) bool { | ||
| return v[j].Compare(v[i]) > 0 | ||
| }) |
| for i, pin := range v { | ||
| m[pin] = &TwinOrder{} | ||
| pinIdx[pin] = i | ||
| } |
| } | ||
|
|
||
| if order.Side == types.SideTypeBuy { | ||
| idx++ |
There was a problem hiding this comment.
could you please add a comment here? explain why idx needs to add 1
|
Great! @kbearXD, I've memorized your address. |
|
Re-estimated karma: this pull request may get 558 BBG |
|
Hi @kbearXD, Well done! 563 BBG has been sent to your polygon wallet. Please check the following tx: https://polygonscan.com/tx/0x5d1b3b662667d39a33cd33ccab8306d4a469ac13004a6fa8a651562e0a1f0a34 Thank you for your contribution! |
No description provided.