Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Fix duplicate RMA values and add test cases #1357

Merged
merged 2 commits into from Oct 24, 2023

Conversation

narumiruna
Copy link
Collaborator

No description provided.

@narumiruna narumiruna requested a review from c9s October 24, 2023 08:50
@bbgokarma-bot
Copy link

Welcome back! @narumiruna, This pull request may get 355 BBG.

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #1357 (2a9fd10) into main (4c16546) will increase coverage by 0.02%.
Report is 5 commits behind head on main.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1357      +/-   ##
==========================================
+ Coverage   20.92%   20.95%   +0.02%     
==========================================
  Files         566      566              
  Lines       40559    40556       -3     
==========================================
+ Hits         8487     8498      +11     
+ Misses      31455    31439      -16     
- Partials      617      619       +2     
Files Coverage Δ
pkg/indicator/v2/rma.go 75.75% <75.00%> (-2.03%) ⬇️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c16546...2a9fd10. Read the comment docs.

@narumiruna narumiruna merged commit 4f35f21 into main Oct 24, 2023
4 checks passed
@narumiruna narumiruna deleted the narumi/rma-test-cases branch October 24, 2023 09:01
@bbgokarma-bot
Copy link

Hi @narumiruna,

Well done! 365 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0xa0ae0bfcc81416e1ec99713231620b180bcc11f7ce223c69558a73d41e3b86a8

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants