FEATURE: query trades from db page by page #1376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycdesu
requested review from
c9s,
kbearXD,
gx578007,
narumiruna,
bailantaotao and
chechiachang
|
Welcome back! @ycdesu, This pull request may get 220 BBG. |
Codecov Report
@@ Coverage Diff @@
## main #1376 +/- ##
==========================================
- Coverage 20.92% 20.92% -0.01%
==========================================
Files 568 568
Lines 40774 40781 +7
==========================================
Hits 8533 8533
- Misses 31609 31616 +7
Partials 632 632
Continue to review full report in Codecov by Sentry.
|
c9s
approved these changes
Oct 31, 2023
ycdesu
force-pushed
the
feature/query-trades-pagination
branch
from
9e28c9e
to
1d2e46e
Compare
|
Re-estimated karma: this pull request may get 227 BBG |
bailantaotao
approved these changes
Oct 31, 2023
gx578007
approved these changes
Oct 31, 2023
narumiruna
approved these changes
Oct 31, 2023
c9s
approved these changes
Oct 31, 2023
c9s
changed the title
|
Hi @ycdesu, Well done! 232 BBG has been sent to your polygon wallet. Please check the following tx: https://polygonscan.com/tx/0xd2e77c9c264ee1dc4c3f72f99b27daae6436b801aa05949d4ae9e18e865ece56 Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Untiloptions so we can query trades from db page by page. Note thatUntilis exclusive.symbolclause will be added only if it's not an empty string. I think it should not affect existing behavior. Please review that thanks.