Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: [bitget] add query open orders #1392

Merged
merged 2 commits into from Nov 9, 2023

Conversation

bailantaotao
Copy link
Collaborator

@bbgokarma-bot
Copy link

Welcome back! @bailantaotao, This pull request may get 838 BBG.

Copy link

codecov bot commented Nov 5, 2023

Codecov Report

Merging #1392 (2d650cd) into main (00d4805) will increase coverage by 0.21%.
Report is 28 commits behind head on main.
The diff coverage is 59.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1392      +/-   ##
==========================================
+ Coverage   20.99%   21.21%   +0.21%     
==========================================
  Files         568      572       +4     
  Lines       40818    41176     +358     
==========================================
+ Hits         8571     8734     +163     
- Misses      31614    31804     +190     
- Partials      633      638       +5     
Files Coverage Δ
pkg/exchange/bitget/bitgetapi/v2/client.go 0.00% <0.00%> (ø)
...bitget/bitgetapi/v2/get_unfilled_orders_request.go 0.00% <0.00%> (ø)
pkg/exchange/bitget/convert.go 91.96% <94.20%> (+3.59%) ⬆️
pkg/exchange/bitget/bitgetapi/v2/types.go 0.00% <0.00%> (ø)
pkg/exchange/bitget/exchange.go 0.00% <0.00%> (ø)

... and 11 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00d4805...2d650cd. Read the comment docs.

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 892 BBG

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 897 BBG

)

type Exchange struct {
key, secret, passphrase string

client *bitgetapi.RestClient
client *bitgetapi.RestClient
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this v3? call it v3client?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, i assume the client is v1, so i don't want to rename it

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it will be deprecated soon...

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 938 BBG

@bailantaotao bailantaotao merged commit e70c04c into main Nov 9, 2023
4 checks passed
@bailantaotao bailantaotao deleted the edwin/bitget/QueryOpenOrders branch November 9, 2023 01:11
@bbgokarma-bot
Copy link

Hi @bailantaotao,

Well done! 943 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0x2bd9264006e4e00fd5dc149ad18cdb7e7a6e5ecc79d376388abe24a019827853

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants