Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: [bitget] use v2 symbols #1413

Merged
merged 1 commit into from Nov 14, 2023
Merged

Conversation

bailantaotao
Copy link
Collaborator

@bailantaotao bailantaotao commented Nov 14, 2023

https://www.bitget.com/zh-CN/api-doc/spot/market/Get-Symbols

The big difference between v1 and v2 is that in v2, there is no post-fix on the symbol(e.q. BTCUSDT_SPBL), so we don't need to handle it

@bbgokarma-bot
Copy link

Welcome back! @bailantaotao, This pull request may get 1010 BBG.

@bailantaotao bailantaotao requested review from c9s and ycdesu and removed request for c9s November 14, 2023 06:33
@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 452 BBG

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #1413 (5e5b8e1) into main (868d48b) will increase coverage by 0.00%.
The diff coverage is 54.54%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1413   +/-   ##
=======================================
  Coverage   21.23%   21.23%           
=======================================
  Files         579      580    +1     
  Lines       42017    42016    -1     
=======================================
  Hits         8924     8924           
+ Misses      32445    32444    -1     
  Partials      648      648           
Files Coverage Δ
pkg/exchange/bitget/convert.go 90.97% <85.71%> (+0.67%) ⬆️
...xchange/bitget/bitgetapi/v2/get_symbols_request.go 0.00% <0.00%> (ø)
pkg/exchange/bitget/exchange.go 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 868d48b...5e5b8e1. Read the comment docs.

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 693 BBG

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 467 BBG

@bailantaotao bailantaotao merged commit beb20a8 into main Nov 14, 2023
10 checks passed
@bailantaotao bailantaotao deleted the edwin/bitget/use-v2-symbols branch November 14, 2023 12:19
@bbgokarma-bot
Copy link

Hi @bailantaotao,

Well done! 472 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0xeb4c1fe4136e5e75ff684c7961da47ea39ee6dee8a375a2bb9fcae5d5e049ad4

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants