Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: [xdepthmaker] remove shared trade collector and fix hedge #1466

Merged
merged 3 commits into from Dec 20, 2023

Conversation

c9s
Copy link
Owner

@c9s c9s commented Dec 20, 2023

Remove the shared trade collector and order store, simplify the code also fix some race conditions

@bbgokarma-bot
Copy link

Welcome back! @c9s, This pull request may get 220 BBG.

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 228 BBG

@c9s c9s enabled auto-merge December 20, 2023 14:29
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (a4f996c) 21.33% compared to head (58321e8) 21.33%.

❗ Current head 58321e8 differs from pull request most recent head 3ba1621. Consider uploading reports for the commit 3ba1621 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1466   +/-   ##
=======================================
  Coverage   21.33%   21.33%           
=======================================
  Files         591      591           
  Lines       43473    43467    -6     
=======================================
  Hits         9274     9274           
+ Misses      33524    33518    -6     
  Partials      675      675           
Files Coverage Δ
pkg/strategy/xdepthmaker/strategy.go 15.04% <0.00%> (+0.14%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4f996c...3ba1621. Read the comment docs.

@c9s c9s merged commit 26f7d86 into main Dec 20, 2023
2 checks passed
@c9s c9s deleted the c9s/fix-xdepthmaker branch December 20, 2023 14:37
@bbgokarma-bot
Copy link

Hi @c9s,

Well done! 238 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0xaaebe5c2fac11491bc1847f1328a8d2d43f14d8bc1e1077f10b8298d34159896

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants