Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE: [xnav] add cron schedule #1470

Merged
merged 1 commit into from Jan 3, 2024
Merged

FEATURE: [xnav] add cron schedule #1470

merged 1 commit into from Jan 3, 2024

Conversation

narumiruna
Copy link
Collaborator

No description provided.

@narumiruna narumiruna requested a review from c9s December 23, 2023 08:27
@bbgokarma-bot
Copy link

Welcome back! @narumiruna, This pull request may get 231 BBG.

@codecov Codecov
Copy link

codecov bot commented Dec 23, 2023 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f4941be) 21.32% compared to head (5592d93) 21.32%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1470   +/-   ##
=======================================
  Coverage   21.32%   21.32%           
=======================================
  Files         591      591           
  Lines       43482    43482           
=======================================
  Hits         9274     9274           
  Misses      33533    33533           
  Partials      675      675

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4941be...5592d93. Read the comment docs.

c9s
c9s reviewed Dec 26, 2023
View reviewed changes
pkg/strategy/xnav/strategy.go Outdated Show resolved Hide resolved
c9s
c9s reviewed Dec 26, 2023
View reviewed changes
pkg/strategy/xnav/strategy.go Outdated
go func() {
ticker := time.NewTicker(util.MillisecondsJitter(s.Interval.Duration(), 1000))
defer ticker.Stop()
if s.Schedule != "" {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be one of "Schedule" or "Interval" ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 259 BBG

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 263 BBG

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 268 BBG

@narumiruna narumiruna marked this pull request as ready for review December 26, 2023 09:12
@c9s c9s merged commit 3dca9aa into main Jan 3, 2024
4 checks passed
@c9s c9s deleted the narumi/xnav/schedule branch January 3, 2024 08:38
@bbgokarma-bot
Copy link

Hi @narumiruna,

Well done! 293 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0x98545d54d5bec0b71b64ba31f56861013d30eac283b415cf1d26c925edddc620

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c9s c9s c9s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@narumiruna @bbgokarma-bot @c9s