Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: add DisableMarketDataStore option #1471

Merged
merged 1 commit into from
Dec 26, 2023

Conversation

c9s
Copy link
Owner

@c9s c9s commented Dec 26, 2023

No description provided.

@bbgokarma-bot
Copy link

Welcome back! @c9s, This pull request may get 214 BBG.

@c9s c9s requested review from gx578007 and kbearXD December 26, 2023 02:53
Copy link

codecov bot commented Dec 26, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (7f8a331) 21.33% compared to head (8878005) 21.32%.
Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1471      +/-   ##
==========================================
- Coverage   21.33%   21.32%   -0.01%     
==========================================
  Files         591      591              
  Lines       43465    43481      +16     
==========================================
  Hits         9274     9274              
- Misses      33516    33532      +16     
  Partials      675      675              
Files Coverage Δ
pkg/bbgo/config.go 40.30% <ø> (ø)
pkg/bbgo/session.go 8.25% <0.00%> (-0.02%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f8a331...8878005. Read the comment docs.

@c9s c9s merged commit f4941be into main Dec 26, 2023
2 of 4 checks passed
@c9s c9s deleted the c9s/add-DisableMarketDataStore-option branch December 26, 2023 04:01
@bbgokarma-bot
Copy link

Hi @c9s,

Well done! 224 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0x77c71a084403c687bbe2d910f285eb184666a486957915fe152b18b3e98a15e6

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants