Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACTOR: [xgap] refactor with common strategy #1480

Merged
merged 1 commit into from Jan 6, 2024

Conversation

narumiruna
Copy link
Collaborator

No description provided.

@bbgokarma-bot
Copy link

Welcome back! @narumiruna, This pull request may get 213 BBG.

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 218 BBG

@narumiruna narumiruna marked this pull request as ready for review January 5, 2024 02:45
@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 227 BBG

@c9s
Copy link
Owner

c9s commented Jan 6, 2024

build failed

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 242 BBG

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 242 BBG

@narumiruna
Copy link
Collaborator Author

build failed

#1481

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 257 BBG

Copy link

codecov bot commented Jan 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4654022) 21.28% compared to head (012fc33) 21.28%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1480   +/-   ##
=======================================
  Coverage   21.28%   21.28%           
=======================================
  Files         596      596           
  Lines       43933    43933           
=======================================
  Hits         9349     9349           
  Misses      33907    33907           
  Partials      677      677           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4654022...012fc33. Read the comment docs.

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 262 BBG

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 267 BBG

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 278 BBG

@narumiruna narumiruna merged commit 9db6890 into main Jan 6, 2024
4 checks passed
@narumiruna narumiruna deleted the narumi/xgap/refactor branch January 6, 2024 07:18
@bbgokarma-bot
Copy link

Hi @narumiruna,

Well done! 283 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0x5ec6393095e26913750769a36db8fac1d7aeb0841ee7ba02c0808a4c61231e0a

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants