Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACTOR: [okx] query markets #1490

Merged
merged 2 commits into from Jan 9, 2024
Merged

REFACTOR: [okx] query markets #1490

merged 2 commits into from Jan 9, 2024

Conversation

bailantaotao
Copy link
Collaborator

No description provided.

@bbgokarma-bot
Copy link

Welcome back! @bailantaotao, This pull request may get 546 BBG.

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (a680df2) 21.54% compared to head (6e160e7) 21.52%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1490      +/-   ##
==========================================
- Coverage   21.54%   21.52%   -0.02%     
==========================================
  Files         598      599       +1     
  Lines       44151    44121      -30     
==========================================
- Hits         9511     9499      -12     
+ Misses      33942    33929      -13     
+ Partials      698      693       -5     
Files Coverage Δ
...hange/okex/okexapi/get_instruments_info_request.go 100.00% <100.00%> (ø)
pkg/exchange/okex/okexapi/public.go 53.12% <ø> (+2.37%) ⬆️
pkg/exchange/okex/exchange.go 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a680df2...6e160e7. Read the comment docs.

@bailantaotao bailantaotao merged commit 2beec1d into main Jan 9, 2024
3 of 4 checks passed
@bailantaotao bailantaotao deleted the edwin/okx/query-mkts branch January 9, 2024 05:23
@bbgokarma-bot
Copy link

Hi @bailantaotao,

Well done! 556 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0x73d30d3647f3f5c2ff7e793647a86f4bfbf6e3fbcd31006740df57bc45245401

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants