Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: [okx] fix queryTrades and queryOrderTrade api #1501

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

bailantaotao
Copy link
Collaborator

@bailantaotao bailantaotao commented Jan 15, 2024

The previous implementation result is unexpected, so i fix something and make it consistent with other exchange implementations.

@bbgokarma-bot
Copy link

Welcome back! @bailantaotao, This pull request may get 473 BBG.

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 478 BBG

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (cee61c1) 21.70% compared to head (11506fb) 21.75%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1501      +/-   ##
==========================================
+ Coverage   21.70%   21.75%   +0.05%     
==========================================
  Files         606      606              
  Lines       44118    44127       +9     
==========================================
+ Hits         9576     9602      +26     
+ Misses      33847    33830      -17     
  Partials      695      695              
Files Coverage Δ
pkg/exchange/okex/convert.go 26.46% <100.00%> (+7.35%) ⬆️
...ge/okex/okexapi/get_transaction_history_request.go 0.00% <ø> (ø)
pkg/exchange/okex/exchange.go 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cee61c1...11506fb. Read the comment docs.

@bailantaotao bailantaotao merged commit 735123b into main Jan 16, 2024
4 checks passed
@bailantaotao bailantaotao deleted the edwin/okx/query-trade branch January 16, 2024 01:19
@bbgokarma-bot
Copy link

Hi @bailantaotao,

Well done! 488 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0xa3cf40bbfb3eb24d8a21890fb69a0545f7f0bf44579164cdf16054455ac444ac

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants