Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: [okx] fix trade id #1530

Merged
merged 1 commit into from Feb 15, 2024
Merged

FIX: [okx] fix trade id #1530

merged 1 commit into from Feb 15, 2024

Conversation

bailantaotao
Copy link
Collaborator

@bailantaotao bailantaotao commented Feb 7, 2024

In the past, I used the bill ID as the trade ID because OKX only supports querying trades by bill ID. However, the bill ID is not supported on websocket events.

I updated the implementation, handling the bill ID as a filter in the loop instead of getting the ID from outside, even if you use batch.query.

@bbgokarma-bot
Copy link

Welcome back! @bailantaotao, This pull request may get 238 BBG.

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (d34a410) 21.78% compared to head (262c05f) 21.77%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1530      +/-   ##
==========================================
- Coverage   21.78%   21.77%   -0.02%     
==========================================
  Files         606      606              
  Lines       43931    43941      +10     
==========================================
- Hits         9569     9566       -3     
- Misses      33680    33693      +13     
  Partials      682      682              
Files Coverage Δ
pkg/exchange/okex/convert.go 31.51% <100.00%> (-0.66%) ⬇️
pkg/exchange/okex/exchange.go 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d34a410...262c05f. Read the comment docs.

@bailantaotao bailantaotao merged commit 4bd5c62 into main Feb 15, 2024
3 of 5 checks passed
@bailantaotao bailantaotao deleted the edwin/okx/fix-trade-id branch February 15, 2024 14:33
@bbgokarma-bot
Copy link

Hi @bailantaotao,

Well done! 248 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0xe763bfe4dd0b93e141b3d377096e0dd6e47040804580a6a8d43c7736f455518c

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants