Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: [ActiveOrderBook] use origin order if error occurred #1555

Merged
merged 1 commit into from Mar 5, 2024

Conversation

bailantaotao
Copy link
Collaborator

If errors occur in CancelOrders and QueryOpenOrders, it will result in an infinite loop because the orders have been replaced with an empty slice.

@bbgokarma-bot
Copy link

Welcome back! @bailantaotao, This pull request may get 206 BBG.

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 211 BBG

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 21.74%. Comparing base (a392d8d) to head (751f82b).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1555      +/-   ##
==========================================
- Coverage   21.74%   21.74%   -0.01%     
==========================================
  Files         609      609              
  Lines       44046    44057      +11     
==========================================
  Hits         9579     9579              
- Misses      33785    33796      +11     
  Partials      682      682              
Files Coverage Δ
pkg/bbgo/activeorderbook.go 24.91% <0.00%> (-0.09%) ⬇️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a392d8d...751f82b. Read the comment docs.

Copy link
Owner

@c9s c9s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!!!

@c9s c9s merged commit 43cf40c into main Mar 5, 2024
3 of 5 checks passed
@c9s c9s deleted the edwin/bbgo/fix-order branch March 5, 2024 02:08
@bbgokarma-bot
Copy link

Hi @bailantaotao,

Well done! 221 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0x139a08fc92ba371bce4b8553c65538a5b8a3b06748fdd6fd29bc884fc2135fde

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants