Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor grid panel #732

Merged
merged 5 commits into from Jun 17, 2022
Merged

Refactor grid panel #732

merged 5 commits into from Jun 17, 2022

Conversation

jundesu
Copy link
Contributor

@jundesu jundesu commented Jun 16, 2022

  1. refactor components and apply typescript interface.
  2. render multiple panels according to your comment.

image

@jundesu jundesu requested a review from c9s June 16, 2022 14:48
@bbgokarma-bot
Copy link

Welcome back! @jundesu, This pull request may get 576 BBG.

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 583 BBG

@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2022

Codecov Report

Merging #732 (95b4a51) into main (df89183) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #732   +/-   ##
=======================================
  Coverage   19.29%   19.29%           
=======================================
  Files         334      334           
  Lines       25437    25437           
=======================================
  Hits         4908     4908           
  Misses      20050    20050           
  Partials      479      479           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df89183...95b4a51. Read the comment docs.

@c9s c9s merged commit 01202e3 into main Jun 17, 2022
@c9s c9s deleted the refactor-grid-panel branch June 17, 2022 10:54
@bbgokarma-bot
Copy link

Hi @jundesu,

Well done! 593 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0xbca718dc248a977ec203b56d67b1294f9cebbc29dd69f7fabcc868a11ed2a1af

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants