Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: clean up bbgo.Notifiability #742

Merged
merged 2 commits into from Jun 19, 2022
Merged

refactor: clean up bbgo.Notifiability #742

merged 2 commits into from Jun 19, 2022

Conversation

c9s
Copy link
Owner

@c9s c9s commented Jun 19, 2022

No description provided.

@bbgokarma-bot
Copy link

Welcome back! @c9s, This pull request may get 356 BBG.

@codecov-commenter
Copy link

Codecov Report

Merging #742 (1562194) into main (eacd1f1) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #742   +/-   ##
=======================================
  Coverage   19.01%   19.01%           
=======================================
  Files         340      340           
  Lines       25668    25668           
=======================================
  Hits         4881     4881           
  Misses      20308    20308           
  Partials      479      479           
Impacted Files Coverage Δ
pkg/bbgo/order_executor_general.go 0.00% <0.00%> (ø)
pkg/strategy/bollmaker/strategy.go 2.29% <ø> (ø)
pkg/strategy/xbalance/strategy.go 2.34% <ø> (ø)
pkg/strategy/xmaker/strategy.go 2.68% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eacd1f1...1562194. Read the comment docs.

@c9s c9s merged commit bce64df into main Jun 19, 2022
@c9s c9s deleted the improve/notify-api branch June 19, 2022 05:11
@bbgokarma-bot
Copy link

Hi @c9s,

Well done! 366 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0x12b89668ed13ab2a7e85a1bffbd87294c25e58efae435dfea0de0ee862f45270

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants