(6/7) RFC79: Implement incremental upload of structural variants data #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I removed DaoGeneticProfileSamples.addGeneticProfileSamples(geneticProfileId, orderedSampleList); as it does not seem to be needed. it does not make any sense to store samples in genetic_profile_samples, if you don't use genetic_alteration table at all.
src/main/java/org/mskcc/cbio/portal/scripts/ImportStructuralVariantData.java
Show resolved
Hide resolved
src/main/java/org/mskcc/cbio/portal/scripts/ImportStructuralVariantData.java
Show resolved
Hide resolved
src/main/java/org/mskcc/cbio/portal/scripts/ImportStructuralVariantData.java
Show resolved
Hide resolved
pieterlukasse
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review #39 next.
Please note, to avoid the costly process of rebasing all pull requests (PRs), all feedback will be incorporated into the final PR.