Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(2/7) RFC79: Make study_es_0_inc data pass validation #44

Merged
merged 5 commits into from
Jun 19, 2024

Conversation

forus
Copy link
Contributor

@forus forus commented Jun 4, 2024

  • document how to load study_es_0 study
  • Remove SpringUtil.initDataSource(); from multiple classes as it was causing not used services to fail during initialisation
  • organise imports (remove unused, no wildcard imports) for the classes that lost SpringUtil.initDataSource(); statement.
  • include into the test data (seed_mini.sql) genes that are used by study_es_0 data.

Please review #43 next.

Please note, to avoid the costly process of rebasing all pull requests (PRs), all feedback will be incorporated into the final PR.

Copy link
Member

@pieterlukasse pieterlukasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍
Just a few questions

@forus forus requested a review from pieterlukasse June 11, 2024 19:14
Copy link
Collaborator

@haynescd haynescd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from inc-tab-delimited-uploader to rfc79 June 19, 2024 14:20
@forus forus merged commit 074372f into rfc79 Jun 19, 2024
4 checks passed
@forus forus deleted the make_study_es_0_to_load branch June 19, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants