Skip to content

Commit

Permalink
Update tests and screenshots
Browse files Browse the repository at this point in the history
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <abeshoua@mskcc.org>
  • Loading branch information
Abeshouse, Adam A./Sloan Kettering Institute committed Nov 20, 2019
1 parent 809f3da commit fdc4847
Show file tree
Hide file tree
Showing 20 changed files with 30 additions and 15 deletions.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
5 changes: 3 additions & 2 deletions end-to-end-test/remote/specs/core/mutationsTab.spec.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
var assert = require('assert');
var waitForOncoprint = require('../../../shared/specUtils').waitForOncoprint;
var setOncoprintMutationsMenuOpen = require('../../../shared/specUtils').setOncoprintMutationsMenuOpen;
var setResultsPageSettingsMenuOpen = require('../../../shared/specUtils').setResultsPageSettingsMenuOpen;
var goToUrlAndSetLocalStorage = require('../../../shared/specUtils').goToUrlAndSetLocalStorage;

const CBIOPORTAL_URL = process.env.CBIOPORTAL_URL.replace(/\/$/, "");
Expand All @@ -9,8 +9,9 @@ describe("mutations tab", function() {
it("uses VUS filtering", function() {
goToUrlAndSetLocalStorage(`${CBIOPORTAL_URL}/results/oncoprint?Action=Submit&RPPA_SCORE_THRESHOLD=2.0&Z_SCORE_THRESHOLD=2.0&cancer_study_list=acc_tcga_pan_can_atlas_2018&case_set_id=acc_tcga_pan_can_atlas_2018_cnaseq&data_priority=0&gene_list=HSD17B4&geneset_list=%20&genetic_profile_ids_PROFILE_COPY_NUMBER_ALTERATION=acc_tcga_pan_can_atlas_2018_gistic&genetic_profile_ids_PROFILE_MUTATION_EXTENDED=acc_tcga_pan_can_atlas_2018_mutations&tab_index=tab_visualize`);
waitForOncoprint(60000);
setOncoprintMutationsMenuOpen(true);
setResultsPageSettingsMenuOpen(true);
browser.click('input[data-test="HideVUS"]');
setResultsPageSettingsMenuOpen(false);
browser.waitForExist('a.tabAnchor_mutations');
browser.click('a.tabAnchor_mutations');
browser.waitForVisible('[data-test="LazyMobXTable_CountHeader"]');
Expand Down
23 changes: 11 additions & 12 deletions end-to-end-test/remote/specs/core/oncoprint.spec.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

17 changes: 16 additions & 1 deletion end-to-end-test/shared/specUtils.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,20 @@ function getTextInOncoprintLegend() {
return browser.getText("#oncoprintDiv .oncoprint-legend-div svg");
}

function setResultsPageSettingsMenuOpen(open) {
const button = 'button[data-test="GlobalSettingsButton"]';
const dropdown = 'div[data-test="GlobalSettingsDropdown"]';
browser.waitForVisible(button);
browser.waitUntil(()=>{
if (open === browser.isVisible(dropdown)) {
return true;
} else {
browser.click(button);
return false;
}
}, 10000, `Couldn't ${open ? "open" : "close"} results page settings menu`, 2000);
}

function setOncoprintMutationsMenuOpen(open) {
const mutationColorMenuButton = "#mutationColorDropdown";
const mutationColorMenuDropdown = "div.oncoprint__controls__mutation_color_menu";
Expand Down Expand Up @@ -305,5 +319,6 @@ module.exports = {
getSelectCheckedOptions: getSelectCheckedOptions,
selectCheckedOption: selectCheckedOption,
getOncoprintGroupHeaderOptionsElements:getOncoprintGroupHeaderOptionsElements,
showGsva: showGsva,
setResultsPageSettingsMenuOpen:setResultsPageSettingsMenuOpen,
showGsva: showGsva
};

0 comments on commit fdc4847

Please sign in to comment.