GC - use new group label components for overlap tab and survival tab #2526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamabeshouse
force-pushed
the
group-name-style
branch
from
25f8577
to
df4695e
Compare
|
@adamabeshouse looks good overall. For UpSet plot, I am wondering if it's possible (and looks good) to just add a colored square before the group name? |
|
@jjgao how does this look? If you like it, then should we use this new style also for the clinical tab ticks, and for anywhere else where we show color? Or go with the color on the ordinal? |
|
@adamabeshouse I like the square version. Maybe don't worry about the ticks in clinical tab and I think other tabs look good. |
adamabeshouse
force-pushed
the
group-name-style
branch
from
df4695e
to
13ee628
Compare
adamabeshouse
force-pushed
the
group-name-style
branch
from
13ee628
to
2ca22e3
Compare
adamabeshouse
force-pushed
the
group-name-style
branch
from
2ca22e3
to
9515ffe
Compare
adamabeshouse
force-pushed
the
group-name-style
branch
from
9515ffe
to
6be5f8a
Compare
adamabeshouse
force-pushed
the
group-name-style
branch
from
6be5f8a
to
f2501cf
Compare
kalletlak
approved these changes
Jul 12, 2019
alisman
reviewed
Jul 12, 2019
| @@ -75,7 +79,7 @@ export default class Survival extends React.Component<ISurvivalProps, {}> { | |||
| name, | |||
| color: blendColors(partitionGroupUids.map(uid => uidToGroup[uid].color)), | |||
| value, | |||
| legendText: name | |||
| legendText: JSON.stringify(partitionGroupUids), | |||
There was a problem hiding this comment.
just want to confirm this is intended
There was a problem hiding this comment.
yes its a bit weird but that's how I'm passing it through the system I have rigged up
alisman
approved these changes
Jul 12, 2019
added 3 commits
July 12, 2019 16:57
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <abeshoua@mskcc.org>
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <abeshoua@mskcc.org>
Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <abeshoua@mskcc.org>
adamabeshouse
force-pushed
the
group-name-style
branch
from
f2501cf
to
ff56fcd
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses cBioPortal/cbioportal#6218