New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
validate sample and patient before render the patient view #2728
Conversation
@dippindots |
|
||
if ('caseId' in query) { | ||
patientViewPageStore.setPatientId(query.caseId as string); | ||
const validationPatient = await validatePatient(query.caseId, query.studyId); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this check belongs in the patientViewStore, not here.
When a user submits a request with invalid sample/patient, we already get 404s. So we can accomplish this ticket by properly handling those errors states for the existing mobx promises. In other words, we should just show a message when we detect isError=true here is example |
d3061bc
to
337ed8e
Compare
337ed8e
to
c9cd321
Compare
c9cd321
to
f5ec096
Compare
f5ec096
to
20955e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
20955e3
to
bd0d028
Compare
bd0d028
to
0e1083d
Compare
0e1083d
to
da465ef
Compare
da465ef
to
eeb1dfe
Compare
eeb1dfe
to
ccdb5a4
Compare
ccdb5a4
to
b2e34b2
Compare
b2e34b2
to
a40a814
Compare
a40a814
to
aa1ec19
Compare
validate sample and patient before render the patient view
Fix # cBioPortal/cbioportal#5357.
Changes proposed in this pull request: